fix(fish): use set -p PATH instead of fish_add_path

The reasoning for this is that `fish_add_path` writes to a universal variable that is persisted independently of fish configuration files, and this can result in stale `fish_user_paths` entries when calls to `fish_add_path` are removed from the configuration. Using `set -p PATH` ensures that only the environment is written to.

home/default.nix

@@ -1,14 +1,13 @@
 {
   config,
-  ctpModule,
-  amDiscordModule,
+  inputs,
   ...
 }: {
   home.stateVersion = "23.05";
 
   imports = [
-    ctpModule
-    amDiscordModule
+    inputs.catppuccin.homeManagerModules.catppuccin
+    inputs.am.homeManagerModules.default
 
     ./variables.nix
     ./fonts.nix

home/programs/fish/conf.d/01_basic_env.fish

@@ -2,5 +2,5 @@
 set -x LS_COLORS "$(vivid generate catppuccin-frappe)"
 
 # nix path patches
-fish_add_path /run/current-system/sw/bin
-fish_add_path "/etc/profiles/per-user/$USER/bin"
+set -p PATH /run/current-system/sw/bin
+set -p PATH "/etc/profiles/per-user/$USER/bin"

home/programs/fish/conf.d/02_tooling.fish

@@ -8,9 +8,9 @@ set -x SSH_AUTH_SOCK "$HOME/Library/Group Containers/2BUA8C4S2C.com.1password/t/
 fnm env --use-on-cd | source
 
 # cargo
-fish_add_path "$HOME/.cargo/bin"
+set -p PATH "$HOME/.cargo/bin"
 # deno
-fish_add_path "$HOME/.deno/bin"
+set -p PATH "$HOME/.deno/bin"
 
 # pnpm
 set -x PNPM_HOME "$HOME/Library/pnpm"
@@ -19,9 +19,9 @@ set -x PNPM_HOME "$HOME/Library/pnpm"
 set -x DIRENV_LOG_FORMAT ""
 
 # docker
-fish_add_path "$HOME/.docker/bin"
+set -p PATH "$HOME/.docker/bin"
 # local bin
-fish_add_path "$HOME/.local/bin"
+set -p PATH "$HOME/.local/bin"
 
 # fish
 set fish_greeting